Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter options to GetPipelines API #3645

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Add filter options to GetPipelines API #3645

merged 4 commits into from
Apr 25, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Apr 25, 2024

Separate this change from #3506

I would like to get at least this change into v2.5.0 if possible.

@xoxys xoxys requested a review from a team April 25, 2024 06:48
@xoxys xoxys added server enhancement improve existing features labels Apr 25, 2024
server/api/pipeline.go Outdated Show resolved Hide resolved
server/api/pipeline.go Outdated Show resolved Hide resolved
@xoxys xoxys requested a review from qwerty287 April 25, 2024 07:00
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test, we should add more of them for the api

server/api/pipeline_test.go Outdated Show resolved Hide resolved
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Apr 25, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3645.surge.sh

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some for the other uses of this, but looks good otherwise 👍

server/api/pipeline_test.go Outdated Show resolved Hide resolved
server/api/pipeline_test.go Outdated Show resolved Hide resolved
@xoxys
Copy link
Member Author

xoxys commented Apr 25, 2024

Thanks. Will address this and need to fix the test before we merge it.

@xoxys xoxys added this to the 2.5.0 milestone Apr 25, 2024
@xoxys
Copy link
Member Author

xoxys commented Apr 25, 2024

Thanks for the fast review.

@xoxys xoxys merged commit 9972c24 into main Apr 25, 2024
6 of 7 checks passed
@xoxys xoxys deleted the pipeline-api-filter branch April 25, 2024 07:37
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 25, 2024
1 task
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
Separate this change from
woodpecker-ci#3506

I would like to get at least this change into v2.5.0 if possible.

---------

Co-authored-by: qwerty287 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants