Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable deployments #3570

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

…but if they're enabled, allow for all events. Also add warning that you should only enable it if you trust the users with push access.

closes #3559

@qwerty287 qwerty287 added server enhancement improve existing features labels Mar 29, 2024
@qwerty287 qwerty287 added this to the 2.5.0 milestone Mar 29, 2024
@qwerty287 qwerty287 requested a review from a team March 29, 2024 09:28
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Mar 29, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3570.surge.sh

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 35.98%. Comparing base (e1b574a) to head (819ac16).
Report is 6 commits behind head on main.

❗ Current head 819ac16 differs from pull request most recent head 430479f. Consider uploading reports for the commit 430479f to get more accurate results

Files Patch % Lines
server/api/pipeline.go 0.00% 5 Missing ⚠️
server/api/repo.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   36.00%   35.98%   -0.02%     
==========================================
  Files         231      231              
  Lines       15543    15553      +10     
==========================================
+ Hits         5596     5597       +1     
- Misses       9530     9539       +9     
  Partials      417      417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/docs/20-usage/71-project-settings.md Outdated Show resolved Hide resolved
docs/docs/20-usage/71-project-settings.md Outdated Show resolved Hide resolved
server/api/pipeline.go Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
@xoxys xoxys merged commit eaf1061 into woodpecker-ci:main Apr 2, 2024
6 of 7 checks passed
@qwerty287 qwerty287 deleted the deploy-opt branch April 3, 2024 05:51
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy PRs
3 participants