Support github deploy task

[fernandrone]

Fixes #3445

Support GitHub Deployments 'task' parameter (ref: https://docs.github.com/en/rest/deployments/deployments?apiVersion=2022-11-28#create-a-deployment).

[woodpecker-bot]

Deployment of preview was torn down

[fernandrone]

I've manually this on top of Woodpecker 2.3 on our internal infrastructure and it's working as I'd expect.

Let me know in case there's some manual tests I should be doing or anything else I could do to help get it validated.

[qwerty287]

Code looks good now, I'll try to test later.

[qwerty287]

Can you update your branch or allow access from maintainers?

[fernandrone]

Updated 👍🏻

[qwerty287]

Seems to work. Just two outdated links in schema.

@anbraten Can you check your review again?

[qwerty287]

@anbraten Can you check your review again?

@fernandrone Can you update the branch?

[qwerty287]

@fernandrone maybe you missed it, but we decided to not add separate when branches for task and the one for environment will get deprecated, you should use env vars instead. See #3512 (comment) and following comments

[fernandrone]

Sorry, I had seen the discussion but I thought you were talking about hypotheticals 😅 ("if we were to remove the environment key, then that would be a breaking change...") yeah, sure, I should be able to remote the task key during the weekend.

[pat-s]

@fernandrone To be able to make it into 2.5.0 (which is already overdue) the open points should be resolved within the next days.

[fernandrone]

Here it is -- sorry for the delay. I'm not 100% sure I removed the right ammount of code. I may be able to ship and validate this change in a test environment by Friday but if you also have the means to validate this quickly on your side that'd be appreciated.

[Dan6erbond]

I landed here from the Here is Woodpecker 2.5.0 blog post and while I really like this feature, it's exactly what I needed to allow us to switch from Drone to Woodpecker, it would really be great if the docs also explain a bit clearer how deployments work! The Forges overview also specifically seems to imply that deployments aren't available with Gitea, and I couldn't find docs describing the manual deployment strategy via the UI so I had to run an instance myself just to figure this out.

To be clear, the Workflow syntax page mentions deployment as an event, but even there it claims "only available for GitHub" which doesn't actually seem to be true given the deploy UI:

[pat-s]

Gitea indeed doesn't support the "deployment" even but this is different to "deployments" for pipelines/worfklows. The former is an event, the latter is a "woodpecker feature". I also fell over this a few months ago and was confused.