gitlab cast ForgeRemoteID to string #2994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
=======================================
Coverage 35.35% 35.35%
=======================================
Files 219 219
Lines 14042 14042
=======================================
Hits 4965 4965
Misses 8699 8699
Partials 378 378 ☔ View full report in Codecov by Sentry. |
|
I also tried it and I think the problem is that it actually needs to be an integer instead. Will open a PR tomorrow |
lafriks
reviewed
Dec 22, 2023
| @@ -234,7 +234,7 @@ func (g *GitLab) getProject(ctx context.Context, client *gitlab.Client, mr *mode | |||
| err error | |||
| ) | |||
| if mr != nil && mr.ForgeRemoteID.IsValid() { | |||
| repo, _, err = client.Projects.GetProject(mr.ForgeRemoteID, nil, gitlab.WithContext(ctx)) | |||
| repo, _, err = client.Projects.GetProject(string(mr.ForgeRemoteID), nil, gitlab.WithContext(ctx)) | |||
There was a problem hiding this comment.
If it's integer you can't really do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression of #2981