Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve release workflow #257

Closed
wants to merge 90 commits into from
Closed

Improve release workflow #257

wants to merge 90 commits into from

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 23, 2021 •
edited
Loading

Changes

  • build docker images with kaniko (non-root)

@anbraten anbraten changed the title feat: improve release workflow feat: use goreleaser for release workflow Jul 23, 2021
@6543 6543 added the build CI pipeline related label Jul 24, 2021
6543
6543 reviewed Jul 24, 2021
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
@6543 6543 added this to the 0.14.0 milestone Jul 24, 2021
@6543 6543 changed the title feat: use goreleaser for release workflow Use goreleaser for release workflow Jul 31, 2021
6543
6543 reviewed Jul 31, 2021
View reviewed changes
.woodpecker/.release.yml Outdated Show resolved Hide resolved
@6543 6543 modified the milestones: 0.14.0, 0.15.0 Jul 31, 2021
@6543 6543 mentioned this pull request Jul 31, 2021
Closed
inverse
inverse reviewed Aug 1, 2021
View reviewed changes
.woodpecker/.release.yml Outdated Show resolved Hide resolved
@anbraten anbraten requested a review from 6543 August 1, 2021 07:54
6543
6543 reviewed Aug 19, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& change makefile to use goreleaser too

docker/Dockerfile.server Outdated Show resolved Hide resolved
docker/Dockerfile.server Outdated Show resolved Hide resolved
docker/Dockerfile.agent Outdated Show resolved Hide resolved
docker/Dockerfile.agent.alpine Outdated Show resolved Hide resolved
.woodpecker/.release.yml Outdated Show resolved Hide resolved
@UnlimitedCookies UnlimitedCookies mentioned this pull request Sep 16, 2021
Closed
3 tasks
@anbraten anbraten changed the title feat: improve release workflow Improve release workflow Sep 19, 2021
@anbraten anbraten added the wip label Sep 19, 2021
@UnlimitedCookies
Copy link
Contributor

UnlimitedCookies commented Sep 23, 2021 •
edited
Loading

@anbraten I've got some more questions:
The release.yml is using the docker image anbraten/kaniko. This likely is https://github.com/GoogleContainerTools/kaniko . But is the source of the container image available? (couldn't find a repo on your GitHub account) And does it perhaps make sense to have this inside the woodpecker org?

@anbraten
Copy link
Member Author

@UnlimitedCookies The source of the image is in this repo: release/docker/Dockerfile.kaniko-builder. It makes sense to push it under the woodpeckerci name. Maybe I can get it upstream into kaniko as well.

@anbraten
Copy link
Member Author

Just created a PR GoogleContainerTools/kaniko#1748 for it at kaniko.

@UnlimitedCookies
Copy link
Contributor

@anbraten Thanks for clarifying! This would also be solved by #278

@anbraten anbraten marked this pull request as draft September 24, 2021 10:46
@anbraten anbraten mentioned this pull request Oct 4, 2021
Merged
@anbraten anbraten mentioned this pull request Oct 4, 2021
Merged
@anbraten anbraten removed the wip label Oct 6, 2021
@anbraten anbraten marked this pull request as ready for review October 6, 2021 07:20
@anbraten anbraten removed this from the 0.15.0 milestone Dec 7, 2021
@6543
Copy link
Member

6543 commented Dec 11, 2021

ok I think it's time to resolve conflicts 🗡️

@anbraten anbraten closed this Dec 22, 2021
@anbraten anbraten deleted the release branch December 22, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnlimitedCookies UnlimitedCookies UnlimitedCookies left review comments

@6543 6543 6543 left review comments

@inverse inverse inverse left review comments

Assignees
No one assigned
Labels
build CI pipeline related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anbraten @UnlimitedCookies @6543 @inverse