Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow multi pipeline file to be named .drone.yml #250

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 20, 2021

Closes #239

The check for vars.name !== "drone" was actually not needed as the decision if the title should be shown or not is done by the amount of build.procs.

Screenshots

Multiple pipeline inside .drone/ folder with .drone/.drone.yml and .drone/.drone.yaml files:

https://github.com/anbraten/woodpecker-demo
Screenshot from 2021-07-20 11-39-04

Single pipeline at .drone.yml:

https://github.com/anbraten/woodpecker-demo2
Screenshot from 2021-07-20 11-38-49

Thanks

Thanks to @ygbillet for finding that lines of code already

@6543 6543 added bug Something isn't working ui frontend related labels Jul 20, 2021
@6543 6543 added this to the 0.14.0 milestone Jul 20, 2021
@6543
Copy link
Member

6543 commented Jul 20, 2021

@ygbillet if you can convirm it works I'll merge it - else I'll test it in the next days

code itself looks like a clean plausible fix - thanks !

@ygbillet
Copy link
Contributor

@anbraten : good job 👍
@6543 : works for me.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing & testing

@6543 6543 merged commit 830b036 into woodpecker-ci:master Jul 22, 2021
@6543
Copy link
Member

6543 commented Jul 22, 2021

preparing release on weekend :)

@anbraten anbraten deleted the fix-multi-pipeline-view branch July 22, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invisible pipeline ".drone.yaml" if ".drone" multi pipeline is used
3 participants