-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up config environment variables for server and agent #218
Merged
6543
merged 35 commits into
woodpecker-ci:master
from
marians:server-remove-drone-env-variables
Sep 28, 2021
Merged
Clean up config environment variables for server and agent #218
6543
merged 35 commits into
woodpecker-ci:master
from
marians:server-remove-drone-env-variables
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for WOODPECKER_AGENT_SECRET
TODO: As pointed out in #209 (comment) the XDG_ variable should not be touched here. |
I just reverted the removal of XDG_CACHE_HOME. |
@laszlocph This is ready for a review. |
got conflicts :O |
6543
added
breaking
will break existing installations if no manual action happens
refactor
delete or replace old code
labels
Jun 18, 2021
This comment has been minimized.
This comment has been minimized.
I'll review it soon :) |
6543
reviewed
Sep 28, 2021
6543
approved these changes
Sep 28, 2021
anbraten
reviewed
Sep 28, 2021
6543
approved these changes
Sep 28, 2021
anbraten
approved these changes
Sep 28, 2021
Thanks for taking over! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #209
The goal here is to make consistent use of configuration environment variables prefixed
WOODPECKER_
. Where several variants existed, this PR aims to remove all but one option, leaving the most explicit.This PR only changes server and agent code, but not documentation, in order to keep the PR digestible. Once we have consensus that this is correct, I'll change docs accordingly.
User (rather: admin) facing changes in this PR:
DRONE_
is removed. The accordingWOODPECKER_*
variables must be used instead.WOODPECKER_HOST
replacesDRONE_HOST
, andDRONE_SERVER_HOST
.WOODPECKER_AGENT_SECRET
is used to configure the shared secret which agents use to authenticate against the server. It replacesWOODPECKER_SECRET
,DRONE_SECRET
,WOODPECKER_PASSWORD
,DRONE_PASSWORD
, andDRONE_AGENT_SECRET
.WOODPECKER_DATABASE_DRIVER
replacesDRONE_DATABASE_DRIVER
andDATABASE_DRIVER
.WOODPECKER_DATABASE_DATASOURCE
replacesDRONE_DATABASE_DATASOURCE
andDATABASE_CONFIG
.Todo
DRONE_
useWOODPECKER_
WOODPECKER_AGENT_SECRET
,WOODPECKER_SERVER_HOST
,WOODPECKER_DATABASE_DRIVER
,WOODPECKER_DATABASE_DATASOURCE
)Wait for