Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secrets with "/" in name editable / deletable #1938

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 7, 2023

close #1937

@6543 6543 added bug Something isn't working ui frontend related labels Jul 7, 2023
@6543 6543 added this to the 1.0.0 milestone Jul 7, 2023
@6543 6543 requested a review from anbraten July 7, 2023 01:33
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we migrate to id based api as well?

web/src/lib/api/index.ts Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jul 7, 2023

☝️ sory was a relict that should not be in there - thanks

@6543
Copy link
Member Author

6543 commented Jul 7, 2023

Should we migrate to id based api as well?

well I would move this breaking refactor if so in the next release!

@6543 6543 requested a review from anbraten July 7, 2023 21:42
@6543 6543 merged commit 1d6b073 into woodpecker-ci:master Jul 8, 2023
@6543 6543 deleted the url_encode_secret_names branch July 8, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove/delete/trash a secret
3 participants