Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify users using their remote ID #1732

Merged
merged 7 commits into from
May 11, 2023
Merged

Conversation

qwerty287
Copy link
Contributor

do not use login name as primary ID when logging in

This can be extended later to support changing usernames etc.

@qwerty287 qwerty287 added the refactor delete or replace old code label May 1, 2023
@qwerty287 qwerty287 added this to the 1.0.0 milestone May 1, 2023
@qwerty287 qwerty287 requested a review from a team May 1, 2023 09:46
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change.

server/store/datastore/user.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 31.11% and project coverage change: -0.07 ⚠️

Comparison is base (f3074dd) 39.26% compared to head (fc2baf5) 39.20%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
- Coverage   39.26%   39.20%   -0.07%     
==========================================
  Files         169      169              
  Lines       10815    10831      +16     
==========================================
- Hits         4247     4246       -1     
- Misses       6292     6309      +17     
  Partials      276      276              
Impacted Files Coverage Δ
server/forge/gitea/gitea.go 30.49% <0.00%> (-0.08%) ⬇️
server/forge/github/github.go 13.48% <0.00%> (-0.04%) ⬇️
server/forge/gitlab/gitlab.go 18.52% <0.00%> (-0.04%) ⬇️
server/forge/gogs/gogs.go 47.57% <0.00%> (-0.24%) ⬇️
server/model/user.go 66.66% <ø> (ø)
server/store/datastore/user.go 58.53% <27.27%> (-12.44%) ⬇️
server/forge/bitbucket/convert.go 97.56% <100.00%> (+0.01%) ⬆️
server/forge/bitbucketserver/convert.go 85.89% <100.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anbraten anbraten enabled auto-merge (squash) May 11, 2023 02:28
@anbraten anbraten merged commit 6d2240b into woodpecker-ci:master May 11, 2023
@qwerty287 qwerty287 deleted the user-id branch May 11, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants