Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent check gRPC version against server #1653

Merged
merged 8 commits into from
Mar 19, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 19, 2023

close #1114

As long as the VersionResponse type is not changed the check will fail/pass gracefully

example output:

{"level":"error","error":"GRPC version mismatch","time":"2023-03-19T19:49:09+01:00","message":"Server version next-6923e7ab does report grpc version 2 but we only understand 1"}
GRPC version mismatch

@6543 6543 added agent enhancement improve existing features labels Mar 19, 2023
@6543 6543 added this to the 1.0.0 milestone Mar 19, 2023
@6543
Copy link
Member Author

6543 commented Mar 19, 2023

@lafriks added a deletion nit and code comments ...

@6543 6543 requested a review from lafriks March 19, 2023 19:09
@6543 6543 enabled auto-merge (squash) March 19, 2023 19:40
@6543 6543 merged commit 92614df into woodpecker-ci:master Mar 19, 2023
@6543 6543 deleted the grpc_get_version_first branch March 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show warning if agent's version does not match server's version
2 participants