-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure some wpdb properties exist before accessing them #41290
Conversation
Test Results SummaryCommit SHA: 1860c4b
Please address the following issues prior to merging this pull request: |
Hi @barryhughes, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a possible/optional change, but it's not a blocker. Approving but not merging (since, as you noted, we currently have a problem with one of our required checks).
Co-authored-by: Barry Hughes <[email protected]>
Note that this |
This PR is now being shipped as part of #41269. This was required to make the unit tests pass in the latter. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Fixes test failures that seem to be PHP 8.0 + WordPress 6.4 related. See e.g. this test run.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Note: the e2e tests appear to be broken right now.