Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure some wpdb properties exist before accessing them #41290

Closed
wants to merge 6 commits into from

Conversation

lsinger
Copy link
Contributor

@lsinger lsinger commented Nov 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fixes test failures that seem to be PHP 8.0 + WordPress 6.4 related. See e.g. this test run.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. review change; ensure CI passes

Note: the e2e tests appear to be broken right now.

@lsinger lsinger self-assigned this Nov 8, 2023
@lsinger lsinger changed the title ensure the properties exist before accessing them Ensure some wpdb properties exist before accessing them Nov 8, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results Summary

Commit SHA: 1860c4b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests209501021523m 30s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.
  • INCOMPLETE E2E TEST RUN. We have a total of 227 E2E tests, but only 215 were executed. Note that in CI, E2E tests automatically end when they encounter too many failures.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@lsinger lsinger requested review from a team and barryhughes and removed request for a team November 8, 2023 18:02
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Hi @barryhughes,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left a possible/optional change, but it's not a blocker. Approving but not merging (since, as you noted, we currently have a problem with one of our required checks).

plugins/woocommerce/includes/wc-core-functions.php Outdated Show resolved Hide resolved
@beaulebens
Copy link
Contributor

Note that this mysqli property in particular is being reverted in WP: https://make.wordpress.org/core/2023/11/08/wordpress-6-4-1-rc1-is-now-available/

@lsinger
Copy link
Contributor Author

lsinger commented Nov 8, 2023

This PR is now being shipped as part of #41269. This was required to make the unit tests pass in the latter.

@lsinger lsinger closed this Nov 8, 2023
@lsinger lsinger deleted the fix/failing-test-php8-wp64 branch November 8, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants