-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pnpm once again to fix issues with auto-install-peers #35007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljseay
requested review from
a team and
roykho
and removed request for
a team
October 9, 2022 21:57
github-actions
bot
added
focus: react admin
package: @woocommerce/e2e-environment
Issues related to @woocommerce/e2e-environment package.
package: @woocommerce/api
Issues related to @woocommerce/api package.
package: @woocommerce/e2e-core-tests
Issues related to @woocommerce/e2e-core-tests package.
package: @woocommerce/e2e-utils
Issues related to @woocommerce/e2e-utils package.
package: @woocommerce/api-core-tests
Issues related to @woocommerce/api-core-tests package.
package: @woocommerce/admin-e2e-tests
issues related to @woocommerce/admin-e2e-tests
package: @woocommerce/components
issues related to @woocommerce/components
package: @woocommerce/csv-export
issues related to @woocommerce/csv-export
package: @woocommerce/currency
issues related to @woocommerce/currency
package: @woocommerce/customer-effort-score
issues related to @woocommerce/customer-effort-score
package: @woocommerce/data
issues related to @woocommerce/data
package: @woocommerce/date
issues related to @woocommerce/date
package: @woocommerce/eslint-plugin
issues related to @woocommerce/eslint-plugin
package: @woocommerce/experimental
issues related to @woocommerce/experimental
package: @woocommerce/explat
issues related to @woocommerce/explat
package: @woocommerce/navigation
issues related to @woocommerce/navigation
package: @woocommerce/number
issues related to @woocommerce/number
package: @woocommerce/onboarding
issues related to @woocommerce/onboarding
package: @woocommerce/tracks
issues related to @woocommerce/tracks
package: dependency-extraction-webpack-plugin
issues related to @woocommerce/dependency-extraction-webpack-plugin
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
labels
Oct 9, 2022
Test Results SummaryCommit SHA: a3a564c
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
psealock
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well with pnpm v 713.3. Approving while waiting for a fix to come in regarding linting in #35010
Hi @samueljseay, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: dependency-extraction-webpack-plugin
issues related to @woocommerce/dependency-extraction-webpack-plugin
package: @woocommerce/admin-e2e-tests
issues related to @woocommerce/admin-e2e-tests
package: @woocommerce/api
Issues related to @woocommerce/api package.
package: @woocommerce/api-core-tests
Issues related to @woocommerce/api-core-tests package.
package: @woocommerce/components
issues related to @woocommerce/components
package: @woocommerce/csv-export
issues related to @woocommerce/csv-export
package: @woocommerce/currency
issues related to @woocommerce/currency
package: @woocommerce/customer-effort-score
issues related to @woocommerce/customer-effort-score
package: @woocommerce/data
issues related to @woocommerce/data
package: @woocommerce/date
issues related to @woocommerce/date
package: @woocommerce/e2e-core-tests
Issues related to @woocommerce/e2e-core-tests package.
package: @woocommerce/e2e-environment
Issues related to @woocommerce/e2e-environment package.
package: @woocommerce/e2e-utils
Issues related to @woocommerce/e2e-utils package.
package: @woocommerce/eslint-plugin
issues related to @woocommerce/eslint-plugin
package: @woocommerce/experimental
issues related to @woocommerce/experimental
package: @woocommerce/explat
issues related to @woocommerce/explat
package: @woocommerce/navigation
issues related to @woocommerce/navigation
package: @woocommerce/number
issues related to @woocommerce/number
package: @woocommerce/onboarding
issues related to @woocommerce/onboarding
package: @woocommerce/tracks
issues related to @woocommerce/tracks
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
There were issues with installing dependencies on a monorepo with auto-install-peers enabled. It would crash every time you try and install dependencies and this was causing some serious interruption to dev work.
This fixes that problem by updating the pnpm version constraint (once again) so that users can only use pnpm 7.13.3 and above (where this fix was released: pnpm/pnpm#5467)
How to test the changes in this Pull Request:
npm i -g pnpm
and runpnpm i
with success. (make sure to clear the pnpm cache just in case:pnpm store prune
FOR PR REVIEWER ONLY: