Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/a2p api-core-tests order notes tests #34979

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

nigeljamesstevenson
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Add order notes CRUD tests to increase test coverage

Closes 361-gh-woocommerce/woocommerce-quality .

How to test the changes in this Pull Request:

  1. Pull down code
  2. Navigate to woocommerce/plugins/woocommerce
  3. Execute tests with USE_WP_ENV=1 pnpm playwright test --config=tests/api-core-tests/playwright.config.js tests/api-core-tests/tests/orders/orders-crud.test.js
  4. Tests should pass including new order notes tests

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Test Results Summary

Commit SHA: c78960b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests15800201600m 49s
E2E Tests187002018915m 40s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work on this @nigeljamesstevenson. Everything ran great for me locally:

Screen Shot 2022-10-07 at 08 10 49

In a future task, one thing we may want to consider as we add more tests around orders/order notes would be to break the order notes tests out into their own file (order-notes.test.js or something similar). This also will break it out similar to the API documentation, making it easier to do a quick scan to see if we have coverage of those endpoints.

@zhongruige zhongruige merged commit 1eb02b4 into trunk Oct 7, 2022
@zhongruige zhongruige deleted the add/A2P-create-order-notes-crud-api-core-tests branch October 7, 2022 14:25
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hi @zhongruige, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@nigeljamesstevenson nigeljamesstevenson changed the title api-core-tests order notes tests add/a2p api-core-tests order notes tests Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants