JQuery FlexSlider: Fix innerHeight computation

[gigitux]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Issue #33829 is caused by the innerHeight computation that is done by the library flexslider The computation depends on the dimension of different slides. The problem is that the computation of the height is done BEFORE setting the new dimensions to the slides. This PR fixes this behavior.

⚠️ ESLint

I removed a console.log that I guess is not necessary. Also, ESLint gives me a lot of errors, but I didn't apply the fix, otherwise, the changes would be very massive.

Closes #33829 .

How to test the changes in this Pull Request:

1. Install Storefront.
2. Create a Product and add multiple images to the product.
3. Go to the Product Page.
4. Open the device simulation.
5. Set iPhone 12 Pro and rotate the device orientation.
6. Be sure that the first image of the product, is rendered correctly, and if you click on the page, no element changes height.

I suggest checking the attached video to understand the problem.

178453842-7b2e2f41-b2ca-4239-ac85-24ff6eb93a25.mp4

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?
• Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[github-actions]

Test Results Summary

Commit SHA: 3533522

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	115	0	0	2	0	117	0m 37s
E2E Tests	185	0	0	1	0	186	13m 36s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[barryhughes]

Re-running failed tests (looks like some were temporary glitches, timeouts etc).

[barryhughes]

@gigitux could you add a changelog entry?

pnpm changelog add --filter=plugins/woocommerce

[gigitux]

@gigitux could you add a changelog entry?

pnpm changelog add --filter=plugins/woocommerce

Hi!
Thanks for the suggestion. I added the changelog!

[github-actions]

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

• Add the release: add testing instructions label