Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space between logos in the payment banner experiment #33065

Merged
merged 1 commit into from
May 17, 2022

Conversation

moon0326
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes #33053 .

This PR adjusts the space between payment logos in the payment banner experiment.

How to test the changes in this Pull Request:

  1. Follow test instructions on pbIJXs-1P0-p2
  2. Make sure logos are aligned correctly.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested a review from a team May 16, 2022 20:48
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 16, 2022
@moon0326 moon0326 force-pushed the fix/33053-fix-logo-spacing branch from 79f7456 to 362e984 Compare May 16, 2022 21:00
@botwoo
Copy link
Collaborator

botwoo commented May 16, 2022

📊 Test reports for 79f7456 `` have been published and are accessible through the following links:

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@botwoo
Copy link
Collaborator

botwoo commented May 16, 2022

📊 Test reports for 362e984 Set icon width to 51px have been published and are accessible through the following links:

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moon0326 Thanks for the fix! Looks good and tested well. 🚢

@moon0326 moon0326 merged commit 3f0685d into trunk May 17, 2022
@moon0326 moon0326 deleted the fix/33053-fix-logo-spacing branch May 17, 2022 03:17
@github-actions github-actions bot added this to the 6.6.0 milestone May 17, 2022
@github-actions
Copy link
Contributor

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing Between the Payment Logo Assets Needs Fixing
3 participants