-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product task experiment updates #32960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin
package: @woocommerce/onboarding
issues related to @woocommerce/onboarding
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
labels
May 11, 2022
ilyasfoo
force-pushed
the
dev/follow-up-product-task-experiment
branch
from
May 12, 2022 02:41
5b8b81b
to
713198f
Compare
chihsuan
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyasfoo Thanks for updating this. Looks good and tested well. 💯
Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: @woocommerce/onboarding
issues related to @woocommerce/onboarding
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Follow-up to #32941.
How to test the changes in this Pull Request:
Prerequisite
WooCommerce Admin Test Helper
Tools > WCA Test Helper > Features
experimental-products-task
woocommerce_allow_tracking
option set toyes
Testing old import if not treatment
WooCommerce Admin Test Helper
Tools > WCA Test Helper > Experiments
woocommerce_products_task_layout_stacked
andwoocommerce_products_task_layout_card
for both frontend and backend experiment/wp-admin/admin.php?page=wc-admin&task=appearance
Testing import under treatment
woocommerce_products_task_layout_stacked
orwoocommerce_products_task_layout_card
for backend and frontendTesting trackView
woocommerce_products_task_layout_stacked
orwoocommerce_products_task_layout_card
for frontendlocalStorage.setItem( 'debug', 'wc-admin:*' );
wcadmin_task_view
track in developer console withexperimental_products: true
propOther information:
pnpm nx changelog <project>
?FOR PR REVIEWER ONLY: