Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert @woocommerce/tracks to TS #32937

Merged
merged 4 commits into from
May 11, 2022
Merged

Conversation

chihsuan
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #32681.

  • Convert @woocommerce/tracks to TS
  • Remove declare module '@woocommerce/tracks'; from WCA to enable type checking.

How to test the changes in this Pull Request:

  1. Should able to build woo tracks via pnpm nx build @woocommerce/tracks
  2. Should no TS errors in WCA: pnpm nx ts:check woocommerce-admin

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/tracks issues related to @woocommerce/tracks plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 10, 2022
@chihsuan chihsuan force-pushed the update/convert-woo-tracks-to-ts branch from c684cbd to cd3abeb Compare May 10, 2022 07:29
@chihsuan chihsuan self-assigned this May 10, 2022
@chihsuan chihsuan requested a review from a team May 10, 2022 07:30
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on it 👍

LGTM and tested well 🚀

@chihsuan chihsuan merged commit edbfd5b into trunk May 11, 2022
@chihsuan chihsuan deleted the update/convert-woo-tracks-to-ts branch May 11, 2022 01:57
@github-actions github-actions bot added this to the 6.6.0 milestone May 11, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: @woocommerce/tracks issues related to @woocommerce/tracks plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Convert @woocommerce/tracks to TS package
2 participants