Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center view more/less button for add product task #32870

Merged
merged 2 commits into from
May 6, 2022

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented May 4, 2022

All Submissions:

Changes proposed in this Pull Request:

As confirmed here, theView more product types buttonshould be at the center.

How to test the changes in this Pull Request:

  1. Open the plugins/woocommerce/client/admin/config/development.json and change experimental-products-task to true
  2. Run pnpm nx dev woocommerce-admin
  3. Navigate to WoocCommerce -> Home and click Add my products
  4. Observe view more types button is for at the center.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 4, 2022
@chihsuan chihsuan requested a review from a team May 4, 2022 09:32
@chihsuan chihsuan self-assigned this May 4, 2022
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 🚀

@chihsuan chihsuan merged commit ac87972 into trunk May 6, 2022
@chihsuan chihsuan deleted the update/center-view-more-button branch May 6, 2022 01:22
@github-actions github-actions bot added this to the 6.6.0 milestone May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants