Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TikTok marketing task #32850

Merged
merged 4 commits into from
May 16, 2022
Merged

Add TikTok marketing task #32850

merged 4 commits into from
May 16, 2022

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented May 2, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32778 .

This PR adds the new TikTok for Business plugin to the Marketing task.

This PR must be released after 13355-gh-Automattic/woocommerce.com

How to test the changes in this Pull Request:

  1. Create a fresh site.
  2. Make sure woocommerce_show_marketplace_suggestions is set to no in wp_options table.
  3. Navigate to HTTP://your-site/wp-admin/admin.php?page=wc-admin&task=marketing
  4. Confirm the TikTok plugin is listed under GROW YOUR STORE
  5. Go back to OBW and change the store country to that is not one of in the list. Brunei is a good candidate.
  6. Go back to the marketing task and confirm the plugin is no longer visible.
  7. Go back to OBW and change the store country back.
  8. Go back to the marketing task and click GET STARTED for the TikTok plugin. Make sure the plugin gets installed without any errors.

Screenshots

Screen Shot 2022-05-13 at 3 34 59 PM

Installed
Screen Shot 2022-05-13 at 3 26 25 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 marked this pull request as draft May 2, 2022 22:02
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 2, 2022
@moon0326 moon0326 changed the title Add TikTok extension to the marketing task Add TikTok marketing task May 2, 2022
@moon0326 moon0326 force-pushed the add/32778-tiktok-marketing-task branch from e604a7f to 3431c73 Compare May 13, 2022 22:26
@moon0326 moon0326 requested a review from a team May 13, 2022 22:33
@moon0326 moon0326 marked this pull request as ready for review May 13, 2022 22:34
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moon0326 Thanks for working on this. Looks good and tested well. 👍

@moon0326 moon0326 merged commit 1ef9b2d into trunk May 16, 2022
@moon0326 moon0326 deleted the add/32778-tiktok-marketing-task branch May 16, 2022 02:55
@github-actions github-actions bot added this to the 6.6.0 milestone May 16, 2022
@github-actions
Copy link
Contributor

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketing task: add new TikTok extension
2 participants