Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the date_created column name with a class property in the analytics DataStore #32644

Merged
merged 3 commits into from
May 26, 2022

Conversation

xristos3490
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Please see the issue for the description.

Closes #32643

How to test the changes in this Pull Request:

N/A

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Apr 15, 2022
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xristos3490 Thanks for working on this! I just left a comment and it would be great if you could add a changelog entry via pnpm nx changelog woocommerce

plugins/woocommerce/src/Admin/API/Reports/TimeInterval.php Outdated Show resolved Hide resolved
@xristos3490
Copy link
Member Author

Thanks for the review, @chihsuan! Changelog file added 👍

@botwoo
Copy link
Collaborator

botwoo commented May 25, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog 58abc68
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xristos3490. Looks good! 🚢

@chihsuan chihsuan merged commit 13fe9b4 into trunk May 26, 2022
@chihsuan chihsuan deleted the update/reports-datastore-date-column branch May 26, 2022 01:24
@github-actions github-actions bot added this to the 6.7.0 milestone May 26, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the date_created column name with a class property in the analytics DataStore
3 participants