-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark marketing task as complete when an extension is installed #32630
Conversation
if ( | ||
count( $installed ) > 0 || | ||
Task::is_task_actioned( 'marketing' ) || | ||
count( $remaining ) === 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, this condition seems a little redundant with the first one, since $remaining
is just the inverse of $installed
, but perhaps it's needed to capture the condition that there are no plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I removed the redundant condition in commit 48a3724
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @octaedro , tests well and looks good. Left a quick question, but not a blocker by any means. 🚢
Thank you @joelclimbsthings for the review, I addressed the change you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right on @octaedro , looks great! 🚢
Hi @octaedro, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Closes #32149.
How to test the changes in this Pull Request:
Free features
and install theMailPoet
extension.Home
screen and verify that the marketing task is marked as completed.MailPoet
extension.Other information:
pnpm nx affected --target=changelog
?FOR PR REVIEWER ONLY: