Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove woocommerce-admin/tests #32621

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Remove woocommerce-admin/tests #32621

merged 2 commits into from
Apr 15, 2022

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Apr 14, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32619.

Removed the woocommerce-admin tests folder since we have moved them into the core.

How to test the changes in this Pull Request:

All Github actions should pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Apr 14, 2022
@chihsuan chihsuan requested a review from a team April 14, 2022 09:37
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Visually confirmed that the e2e tests have been moved to woocommerce/tests/e2e/specs and that they are running on Github actions

@chihsuan chihsuan merged commit 82f7d98 into trunk Apr 15, 2022
@chihsuan chihsuan deleted the remove/admin-test-folder branch April 15, 2022 08:46
@github-actions github-actions bot added this to the 6.6.0 milestone Apr 15, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove woo admin tests directory
2 participants