Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display but do not require Street Address 2 for Vietnam. #32610

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

barryhughes
Copy link
Member

@barryhughes barryhughes commented Apr 13, 2022

Changes proposed in this Pull Request:

Do not hide street address line 2 for Vietnam. I don't think there are any CLDR rules governing this, but see UPU factsheet for Vietnam and this internal conversation p1649771863490019-slack-C7U3Y3VMY.

Closes #32600.

How to test the changes in this Pull Request:

  1. Add an item to the cart, proceed to checkout.
  2. Select Vietnam as the destination country.
  3. With this change, Street Address 2 — "Apartment, suite, unit etc (optional)" — should be visible, but should not be required.

vietnam-street-addr-2

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 13, 2022
@barryhughes barryhughes requested review from a team and Konamiman and removed request for a team April 13, 2022 16:27
@Konamiman Konamiman merged commit 22b8672 into trunk Apr 21, 2022
@Konamiman Konamiman deleted the fix/32600-vietnam branch April 21, 2022 15:03
@github-actions github-actions bot added this to the 6.6.0 milestone Apr 21, 2022
@github-actions
Copy link
Contributor

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Second Address Line is Hidden for Vietnam
2 participants