Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Clarify orderby in REST API docs #35619

Closed
Tracked by #243
peterfabian opened this issue Nov 17, 2022 · 0 comments
Closed
Tracked by #243

[Enhancement]: Clarify orderby in REST API docs #35619

peterfabian opened this issue Nov 17, 2022 · 0 comments
Labels
focus: documentation Issues and PRs related to improving documentation focus: rest api Issues related to WooCommerce REST API. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton WC Core development and maintenance type: enhancement The issue is a request for an enhancement. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@peterfabian
Copy link
Contributor

peterfabian commented Nov 17, 2022 •
edited
Loading

Describe the solution you'd like

Currently, REST API docs says

" orderby | string | Sort collection by object attribute. Options: date, id, include, title, slug, price, popularity and rating. Default is date."

Similar for orders and probably all the data types inherited from WC_REST_CRUD_Controller.

It's not clear if this is created date or modified date.

Describe alternatives you've considered

No response

Additional context

No response
@peterfabian peterfabian added type: enhancement The issue is a request for an enhancement. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team). focus: rest api Issues related to WooCommerce REST API. focus: documentation Issues and PRs related to improving documentation labels Nov 17, 2022
@rrennick rrennick moved this to Core REST API Enhancements in Proton: rest api project Jun 2, 2023
@rrennick rrennick added the team: Proton WC Core development and maintenance label Aug 4, 2023
@coreymckrill coreymckrill mentioned this issue May 21, 2024
Merged
8 tasks
@coreymckrill coreymckrill mentioned this issue May 31, 2024
Open
42 tasks
coreymckrill added a commit to woocommerce/woocommerce-rest-api-docs that referenced this issue Jul 17, 2024
@coreymckrill
Merge pull request #243 from woocommerce/update/fix-reported-issues
799a431 
Updates based on issues in the WooCommerce repo

Fixes woocommerce/woocommerce#43444
Fixes woocommerce/woocommerce#28474
Fixes woocommerce/woocommerce#45924
Fixes woocommerce/woocommerce#45836
Fixes woocommerce/woocommerce#43647
Fixes woocommerce/woocommerce#35619
Refs woocommerce/woocommerce#32037
@github-project-automation github-project-automation bot moved this from Core enhancements to Done in Proton: rest api project Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: documentation Issues and PRs related to improving documentation focus: rest api Issues related to WooCommerce REST API. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton WC Core development and maintenance type: enhancement The issue is a request for an enhancement. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
Proton: rest api project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrennick @peterfabian