-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duplicate product docs #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except that we shouldn't be updating the legacy API docs too.
Ping me when that is removed and I'll re-review/approve!
source/includes/v3/_products.md
Outdated
@@ -1629,6 +1629,115 @@ woocommerce.get("products").parsed_response | |||
<code>tag</code>, <code>shipping_class</code> and <code>pa_*</code> filters are available starting from WooCommerce 2.5. | |||
</aside> | |||
|
|||
## Duplicate product ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation is for the legacy WC API. As such, we shouldn't be updating the doc for this, as our change is for the non-legacy WP REST API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in the commit b8345d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattsherman Could you take another look at this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this documentation @octaedro !
Changes proposed in this Pull Request:
The WooCommerce PR woocommerce/woocommerce#46141 added a new REST API endpoint meant to
duplicate a product
.This PR adds the documentation necessary for that new endpoint
It adds the documentation under
v3
and underwp-api-v3
.How to test the changes in this Pull Request:
build
folder in your project.build
folder and open the following files in your browser:./index.html
(updated @mattsherman - our change is only for the WP API, not the legacy API)./v3.html
Product > Duplicate product
in the sidebar.