Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets: Keychain Setup #7681

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Widgets: Keychain Setup #7681

merged 5 commits into from
Sep 8, 2022

Conversation

Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Sep 7, 2022

Part of #7564

Why

In order to fetch data in the widget extension from the network, we need to have access to the auth token which should be shared in the keychain for security.

How

  • Adds keychain entitelment.
  • Set the authToken to the keychain when the app starts, logins, or switches store.
  • Render a temporary "Authenticated" label in the widget if the widget extension can reach the access token.

Screenshot

Logged in Not logged in
loged-in not-loged-in

Testing Steps

  • Launch the app.
  • Launch the widget extension
  • See that the widget show the authenticated / not authenticated label

@Ecarrion Ecarrion added the feature: widgets iOS Homescreen widgets label Sep 7, 2022
@Ecarrion Ecarrion added this to the 10.3 milestone Sep 7, 2022
@Ecarrion Ecarrion self-assigned this Sep 7, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Sep 7, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 7, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7681-b32087b on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion enabled auto-merge September 8, 2022 14:23
@Ecarrion Ecarrion merged commit 83adece into trunk Sep 8, 2022
@Ecarrion Ecarrion deleted the issue/7564-keychain-sharing branch September 8, 2022 14:53
@Ecarrion Ecarrion linked an issue Sep 9, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: widgets iOS Homescreen widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Widgets] Fetch and Share data store info
3 participants