-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure test results are archived when test suites fail #7647
Conversation
You can test the changes from this Pull Request by:
|
This reverts commit 6fcc82f.
|
||
echo "--- 📦 Zipping test results" | ||
cd fastlane/test_output/ && zip -rq WooCommerce.xcresult.zip WooCommerce.xcresult && cd - | ||
|
||
exit $TESTS_EXIT_STATUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of also adding the echo "^^^ +++"
on non-zero exit code (like is done here) so that Buildkite will have the "Testing" section expanded and open by default — instead of the "Zipping test results" one — when the test failed, to avoid confusion for anyone checking the logs and seeing the failure looking like it was on the zipping instead of the testing step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. I've copied this feature over in 0dcfec0
Generated by 🚫 dangerJS |
Description
The buildkite script stops running after test suite fails, but we still need the test result, well especially when any tests failed. This PR took the approach used in WordPress-iOS repo
Testing instructions
Make sure test results are archived when test failed.
I'll update this description with screenshots of buildkite steps later.Screenshots
N/A
RELEASE-NOTES.txt
if necessary.