Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SwiftLint: I hope this works! #3172

Closed
wants to merge 4 commits into from
Closed

Upgrade SwiftLint: I hope this works! #3172

wants to merge 4 commits into from

Conversation

shiki
Copy link
Member

@shiki shiki commented Nov 18, 2020

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-woocommerce
Copy link

Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@shiki
Temporarily add a violation to SwiftLint
6a3b260 
This is for testing that Hound still works.
hound[bot]
hound bot reviewed Nov 18, 2020
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported. 
The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

@peril-woocommerce
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-woocommerce
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@shiki shiki mentioned this pull request Nov 19, 2020
Open
@shiki
Copy link
Member Author

shiki commented Nov 19, 2020

It didn't work! The reason is in #3173.

@shiki shiki closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shiki