Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS] Adjust pagination height threshold. Fix GhostItemCardView rendering when no more items. #14234

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

[Woo POS] Adjust pagination height threshold. Fix GhostItemCardView rendering when no more items. #14234

wants to merge 8 commits into from

Commits on Oct 29, 2024

  1. Ad threshold multipler to scrolling

    @iamgabrielma
    iamgabrielma committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    592b852 View commit details
    Browse the repository at this point in the history

  2. Avoid infinite loop of loading GhostItemCardView

    @iamgabrielma
    iamgabrielma committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    982bbd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'trunk' into task/pos-pagination-adjust-threshold

    @iamgabrielma
    iamgabrielma committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    09a1bd8 View commit details
    Browse the repository at this point in the history

  2. Do not render ghost card on 1st pull-to-refresh

    @iamgabrielma
    iamgabrielma committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7cb433b View commit details
    Browse the repository at this point in the history

  3. linting

    @iamgabrielma
    iamgabrielma committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7e6061d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Assume there’s always more items on reload 

    We do not need to remove the items since we’re re-setting the list entirely on reload
    @iamgabrielma
    iamgabrielma committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b62cb63 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Disallow loading calls when scrolling up 

    We save and perform an additional check against the lastScrollPosition before fetching the next page, this avoids unnecessary network calls when we’re scrolling up through already loaded products.
    @iamgabrielma
    iamgabrielma committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    117ead6 View commit details
    Browse the repository at this point in the history

  2. Disallow refresh if it’s already loading 

    If we pull-to-refresh fast enough, the system might attempt to reload while the state is still loading
    @iamgabrielma
    iamgabrielma committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b529301 View commit details
    Browse the repository at this point in the history