Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update Xcode version to 16.0 #13928

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

spencertransier
Copy link
Contributor

Just using this draft to validate the xcode-16.0-rc.1

Closes: #

Description

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@pmusolino
Copy link
Member

@spencertransier, we discovered that there are some issues running the app on Xcode 16 peaMlT-SO so these need to be fixed before migrating the CI to the new version of Xcode.

@spencertransier
Copy link
Contributor Author

@pmusolino No problem, I will not merge this one. I was using this draft PR as a way to validate the new Xcode 16 image was working correctly. As usual, I will leave it up to your team to decide when to migrate to Xcode 16 🙂

@staskus
Copy link
Collaborator

staskus commented Sep 12, 2024

Merged Xcode 16 Support, so this PR should build after merging with trunk.

As @pmusolino, there're some other fixes we want to make before building with a new SDK for prod.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 17, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13928-c94f7c2
Version20.8
Bundle IDcom.automattic.alpha.woocommerce
Commitc94f7c2
App Center BuildWooCommerce - Prototype Builds #11280
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

.xcode-version Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants