-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack/image background removal #10656
Draft
jaclync
wants to merge
17
commits into
trunk
Choose a base branch
from
hack/image-background-removal
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removal VM and coordinator.
…er iOS 17 check.
…emoval * hack/UIImage-image-upload: (28 commits) Add test cases for filename/alt text/UIImage changes. Reorder `TaxRate` property order instead of more diffs. Fix broken unit tests from the new media API. Support filename and alt text in `UIImage` image upload. Update image asset type to support `UIImage` in addition to `PHAsset`. Add comment clarifying Add version hash modifier Add custom class to transformables in a new model version Remove an extra check that we don't need and add comment Add test to verify that we return the right rate when a row is selected. Fix tests and add some for the EditableOrderViewModel Improve formatting Pass the tax rate address data to the order. Finish unit test coverage improvements Add proper unit test coverage to package validation with hazmat Fix lint issues Fix unit tests Remove optional from hazmat category in PackageAttributes Refactor toggle reactive approach FIx incorrect validation rules for hazmat changes ... # Conflicts: # WooCommerce/Classes/ViewRelated/Products/Media/ProductImageStatus.swift
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
* trunk: (2628 commits) Bump version number Update metadata translations Update app translations – `Localizable.strings` Avoid using the term parent to refer to the variable product for a product variation Remove unneeded self Update CHANGELOG 16.5 Unit test doesn't throw errors Fix typo in assertion failure Register WordPressThemeStore for AuthenticatedState 11334 Add scrollVerticallyIfNeeded to 16.5 release 11334 Prevent ∞ loop in scrollVerticallyIfNeeded Show variation attributes in the order creation screen Identify parent product as a Bundle in the order creation screen Check price property in unit tests Fix documentation Update tests for WordPressThemeStore Update action and store for loading current theme Update tests for WordPressThemeRemote Add test for WordPressThemeMapper Update MockWordPressThemeRemote ... # Conflicts: # .buildkite/pipeline.yml # .xcode-version # Podfile.lock
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pe5pgL-3EZ-p2
Closes: #
Description
Testing instructions
Screenshots
RELEASE-NOTES.txt
if necessary.