Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack/image background removal #10656

Draft
wants to merge 17 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

jaclync
Copy link
Contributor

@jaclync jaclync commented Sep 8, 2023

Ref: pe5pgL-3EZ-p2

Closes: #

Description

Testing instructions

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…emoval

* hack/UIImage-image-upload: (28 commits)
  Add test cases for filename/alt text/UIImage changes.
  Reorder `TaxRate` property order instead of more diffs.
  Fix broken unit tests from the new media API.
  Support filename and alt text in `UIImage` image upload.
  Update image asset type to support `UIImage` in addition to `PHAsset`.
  Add comment clarifying
  Add version hash modifier
  Add custom class to transformables in a new model version
  Remove an extra check that we don't need and add comment
  Add test to verify that we return the right rate when a row is selected.
  Fix tests and add some for the EditableOrderViewModel
  Improve formatting
  Pass the tax rate address data to the order.
  Finish unit test coverage improvements
  Add proper unit test coverage to package validation with hazmat
  Fix lint issues
  Fix unit tests
  Remove optional from hazmat category in PackageAttributes
  Refactor toggle reactive approach
  FIx incorrect validation rules for hazmat changes
  ...

# Conflicts:
#	WooCommerce/Classes/ViewRelated/Products/Media/ProductImageStatus.swift
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 11, 2023

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr10656-e1742b3
Version16.4
Bundle IDcom.automattic.alpha.woocommerce
Commite1742b3
App Center BuildWooCommerce - Prototype Builds #7048
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from hack/UIImage-image-upload to trunk September 11, 2023 03:16
* trunk: (2628 commits)
  Bump version number
  Update metadata translations
  Update app translations – `Localizable.strings`
  Avoid using the term parent to refer to the variable product for a product variation
  Remove unneeded self
  Update CHANGELOG 16.5
  Unit test doesn't throw errors
  Fix typo in assertion failure
  Register WordPressThemeStore for AuthenticatedState
  11334 Add scrollVerticallyIfNeeded to 16.5 release
  11334 Prevent ∞ loop in scrollVerticallyIfNeeded
  Show variation attributes in the order creation screen
  Identify parent product as a Bundle in the order creation screen
  Check price property in unit tests
  Fix documentation
  Update tests for WordPressThemeStore
  Update action and store for loading current theme
  Update tests for WordPressThemeRemote
  Add test for WordPressThemeMapper
  Update MockWordPressThemeRemote
  ...

# Conflicts:
#	.buildkite/pipeline.yml
#	.xcode-version
#	Podfile.lock
@peril-woocommerce
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@woocommerce woocommerce deleted a comment from wpmobilebot Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants