Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crash in BottomSheetViewController #10254

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Fix Crash in BottomSheetViewController #10254

merged 6 commits into from
Jul 20, 2023

Conversation

pmusolino
Copy link
Member

@pmusolino pmusolino commented Jul 18, 2023 •
edited
Loading

Fixes: #10250

Description

I encountered a crash on iOS 16.4, simulator iPhone 14 Pro Max, while I was trying to add a new product. In the end, I discovered that this crash happens in every screen where we use the BottomSheetViewController component from the WordPressUI library.

Testing instructions

  1. Tap add new physical product
  2. Tap "Add more details"
  3. Tap the "top line" in the bottom sheet.
  4. Crash

Run this PR, you should not be able to expact a crash anymore.

Before merging to trunk

  • Point WordPressUI pod to the release 1.13.1
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pmusolino pmusolino added the type: crash The worst kind of bug. label Jul 18, 2023
@pmusolino pmusolino added this to the 14.6 milestone Jul 18, 2023
@pmusolino pmusolino mentioned this pull request Jul 18, 2023
Merged
1 task
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 18, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr10254-b395bb4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

itsmeichigo
itsmeichigo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

itsmeichigo
itsmeichigo reviewed Jul 19, 2023
View reviewed changes
Podfile Outdated
@@ -90,7 +90,7 @@ target 'WooCommerce' do

wordpress_shared

pod 'WordPressUI', '~> 1.13'
pod 'WordPressUI', :git => 'https://github.com/wordpress-mobile/WordPressUI-iOS.git', :branch => 'task/fix-crash-BottomSheetViewController'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please point this to the library's trunk after merging the fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmeichigo @pmusolino 1.13.1 has been shipped and this branch now points to it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@itsmeichigo itsmeichigo self-assigned this Jul 19, 2023
@pmusolino pmusolino enabled auto-merge July 20, 2023 11:19
@pmusolino pmusolino merged commit f6f0b39 into trunk Jul 20, 2023
@pmusolino pmusolino deleted the issue/10250-crash-in-the-bottom-sheet branch July 20, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@mokagio mokagio mokagio left review comments

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@itsmeichigo itsmeichigo

Labels
type: crash The worst kind of bug.
Projects
None yet
Milestone
14.6
Development

Successfully merging this pull request may close these issues.

[Crash] Crash in the bottom sheet for adding more details to a product
4 participants
@pmusolino @wpmobilebot @mokagio @itsmeichigo