Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAP] M2 Full Feature List screen #10251

Merged
merged 14 commits into from
Jul 19, 2023

Conversation

iamgabrielma
Copy link
Contributor

Closes: #10190

Description

This PR adds the View Full Feature List button in the M2 plan selection view, as well as opens a modal displaying a full feature list per plan.

Original Figma design:

screen 2

Known differences:

There's two known differences that we haven't tackled, mainly because increments complexity. We'll loop with design and update these if are worth the change on a different PR. These are:

  • The navigation bar has a different color (white vs grey): There are no built-in methods to change the color of a SwiftUI NavigationView. A possible alternative is to create some sort of NavigationConfigurator struct that conforms to UIViewControllerRepresentable, this can take a closure that accepts a UINavigationController and modifies its appearance.
  • Some line items are ordered differently: All essential features appear first within a group, while "performance features only" appear latter. As an example:
Design Proposal Implementation
Screenshot 2023-07-18 at 12 23 36 Screenshot 2023-07-18 at 12 23 42

Testing instructions

On a Free Trial site, eligible for IAP (a new site can be created in Menu > Switch Sites > Add New Site) tap on Purchase Now and observe that:

  • Scrolling below the Performance plan, there's a View Full Feature List.
  • Tapping on the button shows the new "Full Feature List screen" in a modal view. Confirm some details:
    • Each group has a title
    • Each group has a list of features
    • Some of these features are marked with a star icon that represents "performance plan only"
    • Some of these features are marked with a 1 or 2 subscript, for example Print Shipping Labels
    • There are line separators between groups
    • The 1 and 2 subscripts appear at the bottom of the view, explaining more details about these features.
- -
Simulator Screen Shot - iPhone 11 Pro - 2023-07-18 at 12 13 21 Simulator Screen Shot - iPhone 11 Pro - 2023-07-18 at 12 13 27

Screenshots

Simulator Screen Recording - iPhone 11 Pro - 2023-07-18 at 11 59 11

@iamgabrielma iamgabrielma added type: task An internally driven task. status: draft This is a draft, still need more work but can be reviewed and commented if asked. feature: in-app purchases Related to In-app purchases and subscriptions labels Jul 18, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 18, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr10251-a09d032 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamgabrielma iamgabrielma removed the status: draft This is a draft, still need more work but can be reviewed and commented if asked. label Jul 18, 2023
@iamgabrielma iamgabrielma marked this pull request as ready for review July 18, 2023 13:10
@iamgabrielma iamgabrielma requested a review from toupper July 18, 2023 14:00
@toupper toupper self-assigned this Jul 19, 2023
Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 I just added a comment to the code. Regarding the design, I have a couple of observations you can consider:

  • The 1 subscripts look too small to me.
  • We could make the space between the section and the footer bigger:

struct Localization {
static let yourStoreFeatureTitle = NSLocalizedString(
"Your Store",
comment: "The title of one of the feature groups offered with paid plans")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As all these comments are basically the same, we could create a helper function to avoid duplication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Changed

@iamgabrielma
Copy link
Contributor Author

Thanks for the review!

The 1 subscripts look too small to me.

I agree 🤔 Since these are the same size as the design specs and changing them would require some sort of switching to use AttributedStrings or Markdown I'll leave it for the backlog for the moment. We may want to change these for * or different symbols

We could make the space between the section and the footer bigger:

Good eye! Addressed here: 6dbb5b0

@iamgabrielma iamgabrielma merged commit ad98753 into trunk Jul 19, 2023
@iamgabrielma iamgabrielma deleted the issue/10190-iap-full-feature-list-screen branch July 19, 2023 16:26
@iamgabrielma iamgabrielma requested a review from lmischner July 20, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: in-app purchases Related to In-app purchases and subscriptions type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IAP] M2 plans full feature list screen
3 participants