-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IAP] M2 Full Feature List screen #10251
[IAP] M2 Full Feature List screen #10251
Conversation
You can test the changes from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct Localization { | ||
static let yourStoreFeatureTitle = NSLocalizedString( | ||
"Your Store", | ||
comment: "The title of one of the feature groups offered with paid plans") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As all these comments are basically the same, we could create a helper function to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Changed
Thanks for the review!
I agree 🤔 Since these are the same size as the design specs and changing them would require some sort of switching to use AttributedStrings or Markdown I'll leave it for the backlog for the moment. We may want to change these for
Good eye! Addressed here: 6dbb5b0 |
Closes: #10190
Description
This PR adds the
View Full Feature List
button in the M2 plan selection view, as well as opens a modal displaying a full feature list per plan.Original Figma design:
Known differences:
There's two known differences that we haven't tackled, mainly because increments complexity. We'll loop with design and update these if are worth the change on a different PR. These are:
NavigationConfigurator
struct that conforms toUIViewControllerRepresentable
, this can take a closure that accepts aUINavigationController
and modifies its appearance.Testing instructions
On a Free Trial site, eligible for IAP (a new site can be created in Menu > Switch Sites > Add New Site) tap on Purchase Now and observe that:
View Full Feature List
.Screenshots