This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable Mini Cart template-parts only for experimental builds #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
Enable Mini Cart template-parts only for experimental builds
gigitux
force-pushed
the
bug/5598-enable-mini-cart-template-parts
branch
from
3b3c306 to
244a774
Compare
|
Size Change: 0 B Total Size: 815 kB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Thanks @gigitux this works great and the code LGTM. My only concern is that we find a way of documenting this functionality somehow for:
- Those who want/need to use it.
- Those who are not aware of it and are debugging why their templates are not showing in a production build.
But I think we can do that separately of this PR. Good work!
|
Your concerns are very great.
I think that we are pretty safe on this topic. We have only one function that returns the block templates, and we added the filter. I think that this is not a problem for our team or for someone who reads our codebase. Maybe we can improve the
I guess that this is the main concern. If someone didn't read the code and didn't find a template can be a problem. Do you have any idea? In any case, as you said, it is better to open another issue. |
gigitux
added a commit
that referenced
this pull request
Jan 24, 2022
gigitux
added a commit
that referenced
this pull request
Jan 24, 2022
gigitux
added a commit
that referenced
this pull request
Jan 24, 2022
* Enable Mini Cart template-parts only for experimental builds #5598 (#5606) Enable Mini Cart template-parts only for experimental builds * bump version to 6.7.3-dev * Empty commit for release pull request * update readme.txt * add testing release notes * Bumping version strings to new version. Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
Mini Carttemplate parts only for experimental builds.NOTE: This PR will be included in release
6.7.3.Fixes #5598
Testing
Manual Testing
How to test the changes in this Pull Request:
Check out this branch
TT1 Blocks.Mini Carttemplate is visible.npm run package-plugin:deploy).Mini Carttemplate is NOT visible.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
TT1 Blocks.Mini Carttemplate is NOT visible.Changelog