This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove wpdb prepare statement in get_category_review_count
method
#5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
the
block: featured category
Issues related to the Featured Category block,
label
Dec 29, 2021
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
December 29, 2021 16:59
Size Change: 0 B Total Size: 819 kB ℹ️ View Unchanged
|
opr
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, and the SQL looks OK - going to let @ralucaStan approve this too since it's a change to DB related code so we need two reviewers.
@ralucaStan just needs your 👁️ |
ralucaStan
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I can tell it looks 👍
gigitux
added
the
type: technical debt
This issue/PR represents/solves the technical debt of the project.
label
Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured category
Issues related to the Featured Category block,
type: technical debt
This issue/PR represents/solves the technical debt of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not valid to call
$wpdb->prepare()
without args. This PR removes it's usage in this way and replaces it with a singleesc_sql
call. Note, the data here is safe anyway because it's cast withabsint
.Fixes #5159
Testing
Changelog