This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Switch to correct view if inner block is selected #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
dinhtungdu
added
status: needs review
type: bug
|
Size Change: -23.3 kB (-3%) Total Size: 817 kB
ℹ️ View Unchanged
|
Aljullu
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Works like a charm! 👏
Code looks good but I have a performance improvement proposal: can we move the views definition from Cart and Mini Cart blocks outside of the component? This way the array is persisted across renders and that would avoid that useEffect() running on every render.
Aljullu
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Thanks for updating the PR @dinhtungdu, this is working like a charm. 👏
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5351
This PR watches for the change of current selected block then switch the current view of the view switcher if an inner block is selected.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog