This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Pass to payment methods a wrapper component that handles the loading state #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +504 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Looks good to me. Just to note, there is some overlap with #5177 where I've added proper typescript definitions. Should we combine documentation/descriptions and refer to the TS rather than repeating in a doc, or have both?
I think there is some extra info in the docs and it might be worth keeping both. Also, as the payment gateways are a topic of interest it might help having this overview in the docs for somebody who just wants to learn more. We can reconsider later. |
Aljullu
added
category: extensibility
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a consistent UI for loading state presented to shoppers in the C&C blocks, we need to provide registered payment methods a component that they could use while they don't want the payment method to be available.
This PR:
Fixes #5013
Other Checks
Screenshots
Images don't reflect the actual size in the page, they are made to support comparing the changes.
Testing
componentskey.Performance Impact
Changelog