Use the LoadingMask component from WooCommerce Blocks for PRB loading status in the Cart and Checkout Blocks #2248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Instead of relying on CSS classes that may change in the future to trigger the loading state on the Payment Request Buttons in the Cart and Checkout Blocks, we instead use the
<LoadableMask />
component exposed in woocommerce/woocommerce-blocks#5135 and released in WooCommerce Blocks v6.4.0.<LoadableMask />
to trigger the loading state.To stick to our general L-2 support policy this PR should not be merged until WooCommerce Blocks 6.6.0 is released.
Testing instructions
Testing the Cart Block
Testing the Checkout Block
I decided not to add automated JS tests for this change since we'd essentially be testing the
<LoadableMask />
component, and the WooCommerce Blocks plugin is already taking care of that.changelog.txt
andreadme.txt
(or does not apply)Post merge