This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add hydration for product data for Single Product block #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hydration for product data for single product block
gigitux
added
focus: performance
The issue/PR is related to performance.
block: single product
Issues related to the single product block.
block-type: product elements
Issues related to Product Element blocks.
labels
Nov 9, 2021
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
November 9, 2021 11:01
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, it makes the block to render much faster! I left a comment below about adding an extra type check, but besides that, LGTM.
Co-authored-by: Albert Juhé Lluveras <[email protected]>
nielslange
added
the
type: enhancement
The issue is a request for an enhancement.
label
Nov 15, 2021
nielslange
changed the title
Add hydration for product data for Single Product block #2698
Add hydration for product data for Single Product block
Nov 15, 2021
nielslange
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Nov 16, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…5107) * Add hydration for product data for single product block woocommerce#2698 Add hydration for product data for single product block * cast product_id variable Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…5107) * Add hydration for product data for single product block woocommerce#2698 Add hydration for product data for single product block * cast product_id variable Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: single product
Issues related to the single product block.
block-type: product elements
Issues related to Product Element blocks.
focus: performance
The issue/PR is related to performance.
skip-changelog
PRs that you don't want to appear in the changelog.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hydration for product data for Single Product Block
Fixes #2698
Testing
Manual Testing
How to test the changes in this Pull Request:
Check out this branch
wc/store/products/${id}
endpointChangelog