Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Hydrate Product Data for the Single Product Block #2698

Closed
mikejolley opened this issue Jun 11, 2020 · 5 comments · Fixed by #5107
Closed

Hydrate Product Data for the Single Product Block #2698

mikejolley opened this issue Jun 11, 2020 · 5 comments · Fixed by #5107
Assignees
@gigitux
Labels
block: single product Issues related to the single product block. block-type: product elements Issues related to Product Element blocks. focus: performance The issue/PR is related to performance. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@mikejolley
Copy link
Member

We should be able to hydrate single product API Data on page load to speed up the initial render, like we have for other blocks.
@mikejolley mikejolley added the focus: performance The issue/PR is related to performance. label Jun 11, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad nerrad added 🔹 block-type: atomic blocks block: single product Issues related to the single product block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Dec 15, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@mikejolley mikejolley added block-type: product elements Issues related to Product Element blocks. and removed 🔹 block-type: atomic blocks labels Apr 9, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 10, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 18, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 18, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 18, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 18, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 20, 2021
@gigitux gigitux self-assigned this Nov 8, 2021
gigitux added a commit that referenced this issue Nov 9, 2021
@gigitux
Add hydration for product data for single product block #2698
1f4a812 
Add hydration for product data for single product block
@gigitux gigitux mentioned this issue Nov 9, 2021
Merged
gigitux added a commit that referenced this issue Nov 9, 2021
@gigitux @Aljullu
Add hydration for product data for Single Product block (#5107)
b88d367 
* Add hydration for product data for single product block #2698

Add hydration for product data for single product block

* cast product_id variable

Co-authored-by: Albert Juhé Lluveras <[email protected]>

Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 14, 2021
@gigitux @Aljullu @jonny-bull
Add hydration for product data for Single Product block (woocommerce#…
393b714 
…5107)

* Add hydration for product data for single product block woocommerce#2698

Add hydration for product data for single product block

* cast product_id variable

Co-authored-by: Albert Juhé Lluveras <[email protected]>

Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 16, 2021
@gigitux @Aljullu @jonny-bull
Add hydration for product data for Single Product block (woocommerce#…
0507cb5 
…5107)

* Add hydration for product data for single product block woocommerce#2698

Add hydration for product data for single product block

* cast product_id variable

Co-authored-by: Albert Juhé Lluveras <[email protected]>

Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gigitux gigitux

Labels
block: single product Issues related to the single product block. block-type: product elements Issues related to Product Element blocks. focus: performance The issue/PR is related to performance. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hydration for product data for Single Product block woocommerce/woocommerce-blocks
3 participants
@mikejolley @nerrad @gigitux