This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix label alignment of the product search in the editor #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix product search margin style on edit page
gigitux
added
type: bug
The issue/PR concerns a confirmed bug.
block: product search
Issues related to the Product Search block.
focus: global styles
Issues that involve styles/css/layout structure.
labels
Nov 4, 2021
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
November 4, 2021 13:46
Size Change: +16 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
ralucaStan
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've also made a suggestion to improve even more the spacing of the block.
gigitux
force-pushed
the
fix/3083-product-search-different-margin
branch
from
November 5, 2021 14:15
cb3de72
to
3efb4ba
Compare
nielslange
changed the title
Product Search: Fix Search label alignment on the edit page
Fix label alignment of the product search in the editor
Nov 16, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…rce#5072) * Fix product search margin style on edit page woocommerce#3083 Fix product search margin style on edit page * fix button size
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…rce#5072) * Fix product search margin style on edit page woocommerce#3083 Fix product search margin style on edit page * fix button size
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: product search
Issues related to the Product Search block.
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the
search
label alignment on the edit page for the blockProduct Search
.Fixes #3083
Screenshots
before - frontend page
before - edit page
current implementation - frontend page
current implementation - edit page
Testing
Manual Testing
How to test the changes in this Pull Request:
Check out this branch
Changelog