Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Search input has different margin in editor and frontend #3083

Closed
Aljullu opened this issue Aug 31, 2020 · 6 comments · Fixed by #5072
Closed

Product Search input has different margin in editor and frontend #3083

Aljullu opened this issue Aug 31, 2020 · 6 comments · Fixed by #5072
Assignees
@gigitux
Labels
block: product search Issues related to the Product Search block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Aug 31, 2020 •
edited by ralucaStan
Loading

To reproduce

Add a Product Search block and notice the input has a margin in the editor but it doesn't in the frontend.

Frontend:
imatge

Editor:
imatge

👆 notice the Search label is aligned with the box in the frontend, but it isn't in the editor.

In Storefront, we have an issue to fix other styling differences for this block between the editor and the frontend (see woocommerce/storefront#1438), but this margin issue seems to be a regression not related to the theme.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: product search Issues related to the Product Search block. focus: global styles Issues that involve styles/css/layout structure. labels Aug 31, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad nerrad added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Dec 15, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 19, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 21, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 25, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 25, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 26, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 27, 2021
@gigitux gigitux self-assigned this Nov 3, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
gigitux added a commit that referenced this issue Nov 4, 2021
@gigitux
Fix product search margin style on edit page #3083
df09350 
Fix product search margin style on edit page
gigitux added a commit that referenced this issue Nov 4, 2021
@gigitux
Fix product search margin style on edit page #3083
9cb2b8e 
Fix product search margin style on edit page
@gigitux gigitux mentioned this issue Nov 4, 2021
Merged
gigitux added a commit that referenced this issue Nov 5, 2021
@gigitux
Product Search: Fix Search label alignment on the edit page (#5072)
1f92c40 
* Fix product search margin style on edit page #3083

Fix product search margin style on edit page

* fix button size
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 14, 2021
@gigitux @jonny-bull
Product Search: Fix Search label alignment on the edit page (woocomme…
4278cb0 
…rce#5072)

* Fix product search margin style on edit page woocommerce#3083

Fix product search margin style on edit page

* fix button size
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 16, 2021
@gigitux @jonny-bull
Product Search: Fix Search label alignment on the edit page (woocomme…
b27c7d0 
…rce#5072)

* Fix product search margin style on edit page woocommerce#3083

Fix product search margin style on edit page

* fix button size
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gigitux gigitux

Labels
block: product search Issues related to the Product Search block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix label alignment of the product search in the editor woocommerce/woocommerce-blocks
3 participants
@nerrad @Aljullu @gigitux