This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs and set them as the aria values
…rs and set them as the aria values
tjcafferkey
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block-type: filter blocks
Issues related to all of the filter blocks.
labels
Sep 24, 2021
nerrad
requested review from
a team and
Aljullu
and removed request for
a team
September 24, 2021 12:53
Size Change: +51 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Unfortunately, I'm not able to reproduce the testing steps (neither the steps to reproduce from the issue) with Orca screen reader + Firefox, I move the knobs but nothing is read by the screen reader. I guess that behavior might depend on the screen reader? 🤔 @opr I see you created the issue and you have VoiceOver + Mac, do you mind if I assign this review to you? |
Works well here! I tested with changing the number of decimals in the price too and it worked great. 🚢 it! |
opr
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block-type: filter blocks
Issues related to all of the filter blocks.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4378
Accessibility
Testing
Manual Testing
How to test the changes in this Pull Request:
Changelog