This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add documentation for registerPaymentMethodExtensionCallbacks #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous type was CanMakePaymentCallback, used for the payment methods's own canMakePayment callbacks, which could also return Promises. In order to eliminate the confusion, a new type has been created that defines callbacks that only return true or false.
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
opr
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Looks great Raluca, beside one typo I made a suggestion for.
I was wondering, could you maybe add a line specifying how you would know what key you have to use in the callbacks object? Maybe like 'This is the value of the $name property used when registering this payment method with the Blocks API'. Feel free to ignore this if you don't think it adds value.
Co-authored-by: Thomas Roberts <[email protected]>
This is a really good suggestion and I've implemented it in d01b874 |
ralucaStan
deleted the
add/4623-registerPaymentMethodExtensionCallbacks-docs
branch
senadir
added
the
focus: documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the
registerPaymentMethodExtensionCallbacksintroduced in #4621Fixes #4623
It also improves the type for callbacks registered by extensions in commit 86f74af: the previous type was CanMakePaymentCallback, used for the payment methods's own
canMakePaymentconfiguration parameter, that returned true || a Promise. In order to eliminate the confusion, a new type has been created to define the extension callbacks that only return true or false.Changelog