Improve the type for callbacks registered by extensions

The previous type was CanMakePaymentCallback, used for the payment methods's own canMakePayment callbacks, which could also return Promises. In order to eliminate the confusion, a new type has been created that defines callbacks that only return true or false.

assets/js/blocks-registry/payment-methods/extensions-config.ts

@@ -1,11 +1,11 @@
 /**
  * External dependencies
  */
-import { CanMakePaymentCallback } from '@woocommerce/type-defs/payments';
+import { CanMakePaymentExtensionCallback } from '@woocommerce/type-defs/payments';
 
 type CanMakePaymentExtensionCallbacks = Record<
 	string,
-	CanMakePaymentCallback
+	CanMakePaymentExtensionCallback
 >;
 export type NamespacedCanMakePaymentExtensionsCallbacks = Record<
 	string,

assets/js/blocks-registry/payment-methods/payment-method-config-helper.ts

@@ -1,7 +1,10 @@
 /**
  * External dependencies
  */
-import type { CanMakePaymentCallback } from '@woocommerce/type-defs/payments';
+import type {
+	CanMakePaymentCallback,
+	CanMakePaymentExtensionCallback,
+} from '@woocommerce/type-defs/payments';
 
 /**
  * Internal dependencies
@@ -38,7 +41,7 @@ export const canMakePaymentWithExtensions = (
 		// Gather all callbacks for paymentMethodName.
 		const namespacedCallbacks: Record<
 			ExtensionNamespace,
-			CanMakePaymentCallback
+			CanMakePaymentExtensionCallback
 		> = {};
 
 		Object.entries( extensionsCallbacks ).forEach(

assets/js/blocks-registry/payment-methods/registry.ts

@@ -5,7 +5,7 @@ import deprecated from '@wordpress/deprecated';
 import type {
 	PaymentMethodConfiguration,
 	ExpressPaymentMethodConfiguration,
-	CanMakePaymentCallback,
+	CanMakePaymentExtensionCallback,
 	PaymentMethodConfigInstance,
 	PaymentMethods,
 	ExpressPaymentMethods,
@@ -81,7 +81,7 @@ export const registerExpressPaymentMethod = (
  */
 export const registerPaymentMethodExtensionCallbacks = (
 	namespace: string,
-	callbacks: Record< string, CanMakePaymentCallback >
+	callbacks: Record< string, CanMakePaymentExtensionCallback >
 ): void => {
 	if ( canMakePaymentExtensionsCallbacks[ namespace ] ) {
 		// eslint-disable-next-line no-console

assets/js/types/type-defs/payments.ts

@@ -43,6 +43,10 @@ export type CanMakePaymentCallback = (
 	cartData: CanMakePaymentArgument
 ) => CanMakePaymentReturnType;
 
+export type CanMakePaymentExtensionCallback = (
+	cartData: CanMakePaymentArgument
+) => boolean;
+
 export interface PaymentMethodIcon {
 	id: string;
 	src: string | null;