-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: remove IntersectionObserver shim #4808
Conversation
I'm wondering should we remove the function entirely because of the shim removal? We only use it in |
Size Change: -17 kB (-1%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
I think so. Lets encourage the usage of the native Web API now that we support it and seeing as though it is only used in one place it should be a fairly simple removal. |
@tjcafferkey I removed the helper, please give this PR another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this re-review. LGTM 🚀
As WordPress 5.8 dropped support for IE11, so does WooCommerce, this PR removes the shim for
IntersectionObserver
. This PR also converts the source file to typescript.Fixes #3035
Accessibility
prefers-reduced-motion
Screenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
npm run dev
.Changelog