Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove IntersectionObserver shim when we drop IE11 support. #3035

Closed
github-actions bot opened this issue Aug 20, 2020 · 5 comments · Fixed by #4808
Closed

Remove IntersectionObserver shim when we drop IE11 support. #3035

github-actions bot opened this issue Aug 20, 2020 · 5 comments · Fixed by #4808
Assignees
@dinhtungdu
Labels
focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: refactor The issue/PR is related to refactoring.

Comments

@github-actions
Copy link
Contributor

Remove IntersectionObserver shim when we drop IE11 support.

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/b2e3d05ec6e9d371d3c8f2068cb86216133b669d/assets/js/base/utils/get-intersection-observer.js#L13-L24

🚀 This issue was generated by the automations bot based on a todo comment in b2e3d05 when #3004 was merged. cc @Aljullu
@nerrad nerrad added focus: components Work that introduces new or updates existing components. type: refactor The issue/PR is related to refactoring. labels Aug 24, 2020
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 15, 2020
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 19, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 21, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 25, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 25, 2021
@nerrad nerrad added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Aug 26, 2021
@dinhtungdu dinhtungdu mentioned this issue Sep 22, 2021
Merged
8 tasks
@dinhtungdu dinhtungdu self-assigned this Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dinhtungdu dinhtungdu

Labels
focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: remove IntersectionObserver shim woocommerce/woocommerce-blocks
2 participants
@nerrad @dinhtungdu