Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the JS exceptions and incorrect quantity value for checkout event tracking #343

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Fix the JS exceptions and incorrect quantity value for checkout event tracking #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1a9ea
Fix the incompatible data structure that causes JS exceptions when se…
eason9487 Dec 26, 2023
d11c908
Fix the incorrect `quantity` value when sending checkout event tracki…
eason9487 Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion assets/js/src/tracking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,19 @@ export const trackCheckoutStep =
return;
}

// compatibility-code "WC >= 8.1" -- The data structure of `storeCart` was (accidentally) changed.
if ( ! storeCart.hasOwnProperty( 'cartTotals' ) ) {
storeCart = {
cartCoupons: storeCart.coupons,
cartItems: storeCart.items,
cartTotals: storeCart.totals,
};
}

trackEvent( step === 0 ? 'begin_checkout' : 'checkout_progress', {
items: storeCart.cartItems.map( getProductFieldObject ),
items: storeCart.cartItems.map( ( item ) =>
getProductFieldObject( item, item.quantity )
),
coupon: storeCart.cartCoupons[ 0 ]?.code || '',
currency: storeCart.cartTotals.currency_code,
value: formatPrice(
Expand Down
Loading