-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document why we use our AJAX API for the Payment Request integration with Blocks #1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README looks good to me 👏
I just added a few suggestions from my experience with the same work in WCPay. Feel free to ignore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I left a few comments, but feel free to merge.
Changes proposed in this Pull Request:
Fixes #1572
client/blocks
in the form of aREADME.md
file that explains why we chose to use our pre-existing AJAX APIs instead of the Blocks API.Testing instructions
N/A
Just review for content and spelling, obvious errors, etc.
grunt
.