Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why we use our AJAX API for the Payment Request integration with Blocks #1588

Merged
merged 9 commits into from
Jun 4, 2021

Conversation

reykjalin
Copy link
Contributor

Changes proposed in this Pull Request:

Fixes #1572

  • Add documentation to client/blocks in the form of a README.md file that explains why we chose to use our pre-existing AJAX APIs instead of the Blocks API.

Testing instructions

N/A

Just review for content and spelling, obvious errors, etc.


  • Make sure your changes respect WordPress' coding standards.
  • Did you make changes, or create a new .js file? If Gruntfile.js exists in the repo, make sure to run grunt.

Copy link
Member

@ricardo ricardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README looks good to me 👏

I just added a few suggestions from my experience with the same work in WCPay. Feel free to ignore them.

client/blocks/README.md Outdated Show resolved Hide resolved
client/blocks/README.md Show resolved Hide resolved
client/blocks/README.md Show resolved Hide resolved
client/blocks/README.md Outdated Show resolved Hide resolved
client/blocks/README.md Outdated Show resolved Hide resolved
Copy link
Member

@ricardo ricardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left a few comments, but feel free to merge.

client/blocks/README.md Show resolved Hide resolved
client/blocks/README.md Outdated Show resolved Hide resolved
client/blocks/README.md Outdated Show resolved Hide resolved
@reykjalin reykjalin merged commit 9ae4c80 into trunk Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document why we chose to use our AJAX APIs instead of the Blocks API for Payment Request Buttons
2 participants