Do not process orders automatically

[bor0]

Fixes #260.

[gedex]

AFAIK, if payment action is set to Authorize, you won't get pinged via PP IPN. The order status is updated by IPN handler, so I think it should remains in on-hold.

[gedex]

Ok, i just tested this with master and apparently it updates the status :/. Testing your branch.

[gedex]

@bor0 I think the culprit of this is sandbox check on IPN handler. PayPal standard in core has the same check. This won't affect live transaction. I'm not sure the reasoning behind that. @mikejolley did you remember why we need to set payment status to completed (in IPN handler) when sandbox is enabled?

The change introduced in this PR will affect transaction when payment action is set to Sale (authorize and capture). So, i suggest we either remove the sandbox check or add another check based on payment action setting.

@yukikatayama @mdmoore does the issue happens on live mode? I imagine if that's the case it will generate lots of tickets.

[mikejolley]

@gedex A longstanding issue in PayPal IPN was that it was not possible to get 'completed' status back - only pending. So to work around this and test payments for real we added the test_ipn check to workaround it.

It only affects sandbox and should not affect live. It would be better to not work around it in other places and just accept that in testing with Sandbox, all transactions are completed.

[bor0]

Thanks for confirming @mikejolley!

Waiting for @yukikatayama / @mdmoore to confirm that it only happens on sandbox before closing it as wont fix.

[mikejolley]

@gedex @bor0 Or we could change the core code to only flip that status if not using authorisations?

Would need some extra testing though - don't want to break things :) And captures may not work in sandbox.

[bor0]

It would have to be both core change (for PayPal) and change in this extension (PPEC), right? Or did you mean changing some other part?

[mikejolley]

@bor0 Just the core test_ipn check

[bor0]

@mikejolley but we have that check both in
Extension
and
Core

So just confirming it needs both changes on the extension and core?

[mikejolley]

Ah yes. I didn't realise PPEC had IPN too.

[yukikatayama]

Update from @mdmoore and my testings - in Live mode, the correct behavior of going to on-hold is working! :) However when changing status to processing/complete, transaction is not made. Details here.

[bor0]

@gedex / @mikejolley another round of review please? (Along with woocommerce/woocommerce#15402)